Adding github actions for CI. #19
Conversation
.github/workflows/run-tests.yml
Outdated
| # Commenting below until code coverage story is done | ||
| # - name: Upload coverage to Codecov | ||
| # uses: codecov/codecov-action@v3 | ||
| # with: | ||
| # files: reports/coverage/*.json | ||
| # flags: frontend,backend |
There was a problem hiding this comment.
VSCode extension has code coverage that's not as straight forward and being worked on it now. Until that story is closed commenting out the lines. npm run compile should be npm run test instead too.
There was a problem hiding this comment.
I think we have to check in with the powers that be about what we are and are not allowed to use for code coverage services too. IIRC it may not be copacetic to use codecov anymore? But I don't remember for sure.
There was a problem hiding this comment.
@khawkins I'll investigate.
There was a problem hiding this comment.
@khawkins I was studying this repo and they don't use Codecov. Instead it looks like they are using jest-coverage. The codecov in my PR comes from lwc-dev-mobile, fyi.
Since I am still investigating how to run code coverage for VSCode extension I want to propose we delete the comment in my code. That way there won't be any confusion later with Codecov. I'll add a task for coverage here once my investigation is done. Will that work with you?
There was a problem hiding this comment.
Yep, that seems like a fine idea to me.
|
With regards to linting failures like this one: why is it reporting both before and after the offending line? |
|
@khawkins Linting locally produces warning once. Gonna investigate. |
No description provided.